New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use incrementing ids for expression keys #553
base: main
Are you sure you want to change the base?
Conversation
@jeremydaly if you're okay with this approach I can update the unit test assertions |
@mitchheddles I think that this approach is a bit problematic, debugging wise. |
Few months ago I started this PR, |
Are you referring to my first implementation with the find and replace, or the newest version? Is your concern that |
I'm referring to both. |
@naorpeled what if this was a configuration option that’s off by default? People can opt into it. Alternatively, we might need custom error handling so we can show more detailed messaging. |
Hmm, would need to discuss this with @ThomasAribart and @jeremydaly. |
@naorpeled please let me know what you decide, I’m keen to keep this one moving |
Haven't received a reply yet, Appreciate your energy, you rock! |
Hey mate, has there been any news yet? We’re currently using a patched version of this library in production for a few weeks now and haven’t had any troubles. It would be great to get this released properly. |
Fixes #94
I've introduced a new
ExpressionId
class which will generate auto incrementing ids for expressions.