Crude implementation to allow map values to be part of the check cond… #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darbio
reviewed
Jan 22, 2021
| : error(`A string for 'attr' or 'size' is required for condition expressions`) | ||
| // Add filter attribute to names | ||
| let attrName = ""; | ||
| const path = typeof attr === 'string' ? attr.split('.') : typeof size === 'string' ? size.split('.') : error(`A string for 'attr' or 'size' is required for condition expressions`);; |
| let attrName = ""; | ||
| const path = typeof attr === 'string' ? attr.split('.') : typeof size === 'string' ? size.split('.') : error(`A string for 'attr' or 'size' is required for condition expressions`);; | ||
| for (let i = 0; i < path.length; i++) { | ||
| names[i == 0 ? `#attr${grp}` : `#attr${grp}${i}`] = i == 0 ? checkAttribute(path[i], (entity ? table[entity].schema.attributes : table.Table.attributes)) : path[i]; |
There was a problem hiding this comment.
I think this would be easier to understand if you used if...else statements rather than inlining it like this. Took me a while to read it and process how it's supposed to work.
| @@ -36,13 +36,13 @@ interface FilterExpression { | |||
| export type FilterExpressions = FilterExpression | FilterExpression[] | FilterExpressions[] | |||
|
|
|||
| const buildExpression = ( | |||
| exp: FilterExpressions, | |||
There was a problem hiding this comment.
There seems to be a lot of noise from your linter/EOL. Can you remove these from the PR?
|
@darbio thank you for the review, let me have another pass at this (it was the fastest way I could make it work at the time) I also need to add a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I have situation where I want to use a value from map type in the schema in the check condition of a updateTransaction function call.
Entity.updateTransaction({ pk: 'TEST', id: details.id, tenantId: details.tenantId, dTimes: { $set: { 'count': { $add: -1 }}}}, { conditions: { attr: "dTimes.count", gt: 0 }})The condition clause was being generated as
#attr1 > :attr1This change will generate the clause as
#attr1.#attr11 > :attr1This probably isn't the best or greatest solution but hopefully it helps explain the problem a little better.
This is a really useful library thank you for the hard work building it.