Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method types overlay 2 #367

Open
Sevi7 opened this issue Nov 14, 2022 · 1 comment
Open

Update method types overlay 2 #367

Sevi7 opened this issue Nov 14, 2022 · 1 comment
Milestone

Comments

@Sevi7
Copy link

Sevi7 commented Nov 14, 2022

Thanks for the quick release of the previous fix! However, the update method types overlay is still not working for me, I found another possible issue:

The return type of update method contains FirstDefined<[O.Pick<Item, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]> and the response type I get for Attributes is {} | undefined.

I think it should be FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]>.
What's more, the response I get is FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]> | {} | undefined. I think there is something more to resolve in order to get rid of that {}

@naorpeled
Copy link
Collaborator

Hey,
can you send your entity config + an example of specific response you would want to see based on that config?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants