get,put,update method type inference incorrect when extending Entity

[ojongerius]

👋 I have an issue with extending entities. When extending the Entity class I see the following unexpected behaviour:

The inferred value for the get, put and update methods return {Get,Put,Update>InputCommand instead of {Get,Put,Update}OutputCommand. When I look your code for the get method at https://github.com/jeremydaly/dynamodb-toolbox/blob/main/src/classes/Entity/Entity.ts#L289 I see that return value is defined as:

Promise<If<B.Not<ShouldExecute<Execute, AutoExecute>>,
    GetCommandInput,
    If<B.Not<ShouldParse<Parse, AutoParse>>,
      GetCommandOutput,
      Compute<O.Update<GetCommandOutput,
        'Item',
        FirstDefined<[MethodItemOverlay, Compute<O.Pick<Item, ResponseAttributes>>]>>>>>

The behaviour I see during type inference is that either Execute or AutoExecute is set to false. The generated JS code behaves as expected AFAICT. This behaviour changes calling those methods with { execute: true }.

As far as I can tell this was introduced by #302 and this behaviour can be changed by changing (https://github.com/jeremydaly/dynamodb-toolbox/blob/main/src/classes/Entity/Entity.ts#L74) from:

  AutoExecute extends boolean = string extends Name ? boolean : true,

to

  AutoExecute extends boolean = true,

But obviously a broader fix would be necessary.

Reproduce:

Config:

 const config = {
    name: 'TestEnt',
    attributes: {
      pk: { partitionKey: true },
      test: { map: 'sk' },
    },
    autoParse: false,
    table: new Table({
      name: 'base-table',
      partitionKey: 'pk',
      DocumentClient,
    }),
  } as const
 
  class TestEntityExtended extends Entity {
    constructor() {
      super(config)
    }
  }

Using this entity inferred return value looks fine, tested with:

  const baseEntity = new Entity(config);
    const baseEntity = new Entity(config);
    const res = baseEntity.get({ pk: 'foo' }) // Promise<GetOutPutCommand>

    type TestExtends = Equals<typeof res, Promise<GetCommandOutput>>
    const testExtends: TestExtends = 1 // Expected output
    expect(testExtends).toBe(1)

Using TestEntityExtended, we get Promise<GetCommandInput>

    const testEntity = new TestEntityExtended()
    const res = testEntity.get({ pk: 'foo' })
    type TestExtends = Equals<typeof res, Promise<GetCommandOutput>>  // FAIL (Promise<GetCommandInput> instead)
    const testExtends: TestExtends = 1 // 
    expect(testExtends).toBe(1)

Working around by passing { execute: true } we get Promise<GetOutPutCommand> and test passes

    const TestEntity = new TestEntityExtended()
    const bar = TestEntity.get({ pk: 'foo' }, { execute: true })
    type TestExtends = Equals<typeof bar, Promise<GetCommandOutput>>
    const testExtends: TestExtends = 1
    expect(testExtends).toBe(1)
  })

[ojongerius]

Pushed demo in #662

[ojongerius]

Similar but not identical: #367

[ojongerius]

Related: #683