docs: improve Fish installation instructions #329
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on feedback in this PR Homebrew/homebrew-core#76864.
|
cc @gcuisinier |
mrmeszaros
reviewed
Jul 30, 2023
| @@ -87,10 +87,12 @@ Continue to the next section to install java. | |||
| **Untested**: While this fork has improved `fish` shell support, it has not been tested by this maintainer. To install `jenv` for Fish according to the contributor's instructions: | |||
|
|
|||
| ```sh | |||
| echo 'set PATH $HOME/.jenv/bin $PATH' >> ~/.config/fish/config.fish | |||
| # The line below is not needed if you installed jenv with Homebrew | |||
| echo 'fish_add_path $HOME/.jenv/bin' >> ~/.config/fish/config.fish | |||
There was a problem hiding this comment.
Also, currently by default fish_add_path uses a universal $fish_user_paths variable - stored in the ~/.config/fish/fish_variables file. While fish_add_path checks for duplicates, it might be worth to use the --global flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on feedback in this PR
Homebrew/homebrew-core#76864.