Update readme with temurin install instructions. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinleturc
reviewed
Aug 28, 2021
There was a problem hiding this comment.
Thanks for the contribution 👍.
I think it could be interesting to update the current Using Two JVMs on macOS section with your suggested changes. The documentation can reflect only the latest brew version.
What do you think?
Also, the AdoptOpenJDK/homebrew-openjdk tap has been deprecated, the temurin cask should be used instead.
Could you update with the new way?
|
Sure. It's the morning right now and I'm half vampire by coding habit. |
mariomui
force-pushed
the
mariomui-readme-update
branch
3 times, most recently
from
8113356
to
11747a3
Compare
Edit spacing
mariomui
force-pushed
the
mariomui-readme-update
branch
from
11747a3
to
2315129
Compare
|
Temurin isn't really ready for prime time so I dont think that temurin instructions should replace the instructions for adoptopen.
|
mariomui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the readme did not include instructions for the changes to cask. brew cask install is deprecated in favor of brew install --cask
Now, the documentation reflects latest guides to installing JENV
References to documentation are below.
https://github.com/AdoptOpenJDK/homebrew-openjdk/tree/master/Casks
https://github.com/Homebrew/homebrew-cask/blob/master/USAGE.md