Skip to content

Commit

Permalink
Merge pull request #353 from monluk/bugfix/multijob_infinite_recursion
Browse files Browse the repository at this point in the history
Bugfix for #255: Multijob infinite recursion when subordinate job is …
  • Loading branch information
balakine committed Mar 25, 2024
2 parents 3a1ef03 + 28cccb9 commit 7c23cef
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,9 @@ public String expandToken(String toExpand, final AbstractBuild<?,?> build, final
*/
private StatusJob getScmChange(Job subjob,PhaseJobsConfig phaseConfig,AbstractBuild build, BuildListener listener,Launcher launcher)
throws IOException, InterruptedException {
/* https://issues.jenkins-ci.org/browse/JENKINS-33821
if ( subjob.disabled ) {
if ( ! subjob.isBuildable() ) {

Check warning on line 171 in src/main/java/com/tikal/jenkins/plugins/multijob/MultiJobBuilder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line

Line 171 is only partially covered, one branch is missing
return StatusJob.IS_DISABLED;
}
*/
if( phaseConfig.isDisableJob() ) {
return StatusJob.IS_DISABLED_AT_PHASECONFIG;
}
Expand Down

0 comments on commit 7c23cef

Please sign in to comment.