[JENKINS-37184] [JENKINS-5124] Log the exception that is thrown if Jenksins can't get info() on a subversion repository using a tunnel #165
Conversation
Log the exception that is thrown if Jenksins can't get info() on a subversion repository using a tunnel. When the repository factory creates the repository, set the tunnel provider based on default svn options.
| @@ -255,6 +256,7 @@ private boolean isSVNRepositoryProjectRoot(SVNRepository repo) { | |||
| return true; | |||
| } | |||
| } catch (SVNException e) { | |||
| LOGGER.log(Level.SEVERE, "An SVN exception occurred", e); | |||
There was a problem hiding this comment.
The message does not provide any value
There was a problem hiding this comment.
It's doesn't? It tells a sysadmin that they have a misconfigured repository line when they specify svn+foo://domain/path and foo is not a configured tunnel in .subversion/config. It's much better then throwing that exception on the floor. It's the only way I would know how to fix the bug.
Removed extra spaces.
|
I believe this patch is ready to be merged. If not, please provide feedback. |
|
Any updates on this PR? |
jglick
changed the title
| @@ -179,6 +179,7 @@ public DescriptorImpl getDescriptor() { | |||
| SVNURL repoURL = SVNURL.parseURIDecoded(getTagsDir()); | |||
|
|
|||
| SVNRepository repo = SVNRepositoryFactory.create(repoURL); | |||
| repo.setTunnelProvider(SubversionSCM.createDefaultSVNOptions()); | |||
There was a problem hiding this comment.
This is not about logging, is it?
|
Well it's been about a year, so I don't remember. I'll review and update the ticket. I can tell you, the efect of this omission is, under some conditions, the list of known braches and tags will not populate a drop down select box. I believe it was like Build Parameterized or some form like that. The root cause of the issue was not being logged. We didn't know what to fix. The feature was unusable. I don't recall what the root cause was, but I feel it was related to the fact that we use ssh+svn and our ssh uses Kerberos for authentication. |
Log the exception that is thrown if Jenksins can't get info() on a subversion repository using a tunnel. When the repository factory creates the repository, set the tunnel provider based on default svn options.