Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: kibana dashboard with support for > 8.0 #382

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 24, 2022

What

Support Kibana version > 8.0 in addition to 7.17.

Changes

  • Use index pattern "traces-apm*,apm-*,logs-apm*,apm-*,metrics-apm*,apm-*"
  • Remove hardcoded graph for Agent Allocation Duration
  • Average Job Durations uses transaction.duration.us

Issue

Closes #378

@v1v v1v requested a review from kuisathaverat as a code owner March 24, 2022 21:52
@v1v v1v added the documentation Improvements or additions to documentation label Mar 24, 2022
@cyrille-leclerc
Copy link
Contributor

Thanks for working on a fix.

I was wondering why we had this attribute ci.pipeline.run.durationMillis which overlaps a lot with the transaction duration (transaction being the root span of the job).

Could we replace our usage of ci.pipeline.run.durationMillis by the transaction.duration.us of the pipeline root spans (e.g. spans matching labels.ci_pipeline_run_result:*). It would mostly needs a conversion from microseconds (us to millis).

With this, could we have a dashboard compatible with 7.x and 8.x?

@v1v
Copy link
Member Author

v1v commented Mar 28, 2022

With this, could we have a dashboard compatible with 7.x and 8.x?

I just updated the new dashboard that's compatible with both versions, thanks for the tip about using the transaction time.

It would mostly needs a conversion from microseconds (us to millis).

IIUC, Kibana does not support aggregations with bucket script -> elastic/kibana#4707

Therefore, it will require to use Kibana Lens to allow this transformation, for now, I didn't make that change but in a follow up to use Kibana Lens for all the graphs instead the traditional Kibana graphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins Kibana Dashboard reports error and is empty in new Elastic 8.1 deployments
3 participants