Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOML DataFormat Support #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlasevich
Copy link

@mlasevich mlasevich commented Oct 6, 2023

This pull requests adds the TOML dataformat library to existing formats (XML, YAML, etc)

Testing done

  • Minimal change, just adds a library
  • Basic Unit test added to ensure it works
  • Manually tested on local instance

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. (N/A) Link to relevant issues in GitHub or Jira
    Options
  5. (N/A) Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@mlasevich mlasevich requested a review from a team as a code owner October 6, 2023 18:22
@jtnord
Copy link
Member

jtnord commented Oct 9, 2023

This pull requests adds the TOML dataformat library to existing formats (XML, YAML, etc)

What plugin needs this (please link to a downstream PR), or is this just because it is part of the bom?

@mlasevich
Copy link
Author

No other PR (yet?).

We would consume this from a Pipeline Library to read TOML files(right now pyproject.toml) . I was initially going to open a PR for utility steps plugin, so that it would have a readTOML next to readJSON and readYAML - but after I looked at it, I realized they are not using Jackson at all, and I decided against trying to add it as a dependency to such a high profile plugin.

Instead I am guessing I would need to create a new one for reatTOML/writeTOML, when I have some time. Meanwhile, just using it from a global pipeline library would be great..

@jtnord
Copy link
Member

jtnord commented Nov 10, 2023

No other PR (yet?).

We would consume this from a Pipeline Library to read TOML files(right now pyproject.toml) . I was initially going to open a PR for utility steps plugin, so that it would have a readTOML next to readJSON and readYAML - but after I looked at it, I realized they are not using Jackson at all, and I decided against trying to add it as a dependency to such a high profile plugin.

Instead I am guessing I would need to create a new one for reatTOML/writeTOML, when I have some time. Meanwhile, just using it from a global pipeline library would be great..

I'm not against adding this here as it is part of the jackson bom, but without a PR or a new plugin to consume it, it has the possibility to just add to the size of the plugin and never be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants