Removed 13 unnecessary stubbings from InstanceConfigurationTest.java

[ARUS2023]

Testing done

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

In our analysis of the project, we observed that

1. 12 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 4 tests InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.testClient. [See changes in InstanceConfigurationTest.java]

2. 10 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method in init are created but are never executed by 4 tests InstanceConfigurationTest.descriptorBootDiskSizeValidation, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.testClient; [See changes in SecondInstanceConfigurationTest.java]

3. 13 unnecessary stubbings which stubbed listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 3 tests InstanceConfigurationTest.descriptorBootDiskSizeValidation, InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testClient; [See changes in ThirdInstanceConfigurationTest.java]

4. 11 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 4 tests InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.descriptorBootDiskSizeValidation. [See changes in FourthInstanceConfigurationTest.java]

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html). We propose below a solution to remove the unnecessary stubbings.