Expand environment variables for sparse checkout path #1066
Conversation
|
|
||
| public class SparseCheckoutPath extends AbstractDescribableImpl<SparseCheckoutPath> implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = -6177158367915899356L; | ||
|
|
||
| @SuppressFBWarnings(value="SE_TRANSIENT_FIELD_NOT_RESTORED", justification="Default value is OK in deserialization") | ||
| public static final transient SparseCheckoutPathToPath SPARSE_CHECKOUT_PATH_TO_PATH = new SparseCheckoutPathToPath(); |
There was a problem hiding this comment.
Won't this change break compatibility for git plugin API consumers that refer to this public field that is being deleted?
It is included in the Javadoc of the current release.
There was a problem hiding this comment.
Updated to keep this variable for API consumers.
| public String apply(@NonNull SparseCheckoutPath sparseCheckoutPath) { | ||
| return sparseCheckoutPath.getPath(); | ||
| } | ||
| public Descriptor<SparseCheckoutPath> getDescriptor() { |
There was a problem hiding this comment.
Please don't make white space changes in the git plugin. The formatting is ugly and inconsistent, but changing white space makes it more difficult to read the changes and more difficult to interact with other proposed changes in the same file.
There was a problem hiding this comment.
I don't understand why the getDescriptor() call moved outside SparseCheckoutPathToPath. What makes that move necessary?
There was a problem hiding this comment.
This was not intentional. Somehow changed on reformating the code in IDE.
| } | ||
|
|
||
| @Extension | ||
| public static class DescriptorImpl extends Descriptor<SparseCheckoutPath> { | ||
| @Override | ||
| public String getDisplayName() { return "Path"; } |
There was a problem hiding this comment.
Please don't make white space only changes in the git plugin. See the contributing file for more details.
There was a problem hiding this comment.
As mentioned this was not intentional either.
| @Extension | ||
| public static class DescriptorImpl extends GitSCMExtensionDescriptor { | ||
| @Override | ||
| public String getDisplayName() { | ||
| return "Sparse Checkout paths"; | ||
| } |
There was a problem hiding this comment.
Why moving so many methods outside the descriptor implementation class? Seems like that will break many things and add unused public methods to the SparseCheckoutPaths object.
| @@ -67,11 +68,11 @@ public boolean equals(Object o) { | |||
| if (this == o) { | |||
| return true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I am not able to resolve these issues.
There was a problem hiding this comment.
I am not able to revert these changes.
raghavgarg098
changed the title
JENKINS-23477
Expand environment variables in sparse checkout path using pattern matching to look for environment variables name.
Checklist
Types of changes