Allow slash in name

[XLordalX]

This adds GitLab nested group support to pipelines.

[jenkins-x-bot]

Hi @XLordalX. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[XLordalX]

/assign @ankitm123

[ankitm123]

Tests would be good to ensure we don't add regression. I added some changes to support nested gitlab repos, I must have missed certain parts. Thanks for looking into this and fixing it :)

[ankitm123]

Does it fix issues around jx pipeline start? Curious ...

[XLordalX]

Yes it does, it gets stuck on the pipeline wait command because it's waiting for the wrong trigger:

waiting up to 20m0s for a trigger to be added to the lighthouse configuration in ConfigMap config in namespace jx for repository: org/subgroup-subproject
you can watch the boot job to update the configuration via: jx admin log
for more information on how this works see: https://jenkins-x.io/v3/about/how-it-works/#importing--creating-quickstarts

notice how it's attempting to wait for org/subgroup-subproject instead oforg/subgroup/subproject (notice the dash was replaced with a slash) which is added to the config ConfigMap. This change fixes that.

[ankitm123]

Did u try --nested-repo flag when importing?

[XLordalX]

Did u try --nested-repo flag when importing?

Yes. This is with —nested-repo.

[XLordalX]

@ankitm123 I'm willing to write tests for this, but I'm not sure what needs to be tested. Can you help me out a bit?

[msvticket]

I think this is the wrong fix for the problem. The method is meant for creating k8s resource names and they can not have /. Instead some other method (possibly new) should be used.