Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Select bottom border for Lumen #87

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

Shashwat986
Copy link

The height of the select tag is larger than other elements. This is vastly more prominent in form elements grouped using has-addons. This PR fixes that.

Old:
Screen Shot 2020-10-08 at 6 50 53 PM

New:
Screen Shot 2020-10-08 at 6 50 17 PM

@Shashwat986
Copy link
Author

Also, quick request. I'm participating in Hacktoberfest, and I'd love for this PR to be eligible for that:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

@RubyHuntsman
Copy link

RubyHuntsman commented Oct 16, 2020

Can you also fix big search button from second input?

@Shashwat986
Copy link
Author

Shashwat986 commented Oct 17, 2020

Good catch! I've added a commit for that too. (Image has is-small for the first element, because I was testing it too)

Screen Shot 2020-10-17 at 11 02 13 AM

@RubyHuntsman
Copy link

Now looks great

@jenil jenil self-assigned this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants