Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastpath] Allow compile-time size computation. #2638

Closed
wants to merge 1 commit into from

Conversation

davidtgoldblatt
Copy link
Member

In LTO-able contexts, if size is a static constant, then so are szind and usize. But: indirecting through a lookup table obscures this fact from the compiler. Instead, we try to detect if size is static and use a constant-foldable computation if it is.

In LTO-able contexts, if size is a static constant, then so are szind and usize.
But: indirecting through a lookup table obscures this fact from the compiler.
Instead, we try to detect if size is static and use a constant-foldable
computation if it is.
@interwq
Copy link
Member

interwq commented Apr 16, 2024

@davidtgoldblatt we have made plan for this (waiting for buckification to fully rollout). You should sync up with us to avoid conflict like this.

@interwq interwq closed this Apr 16, 2024
@davidtgoldblatt
Copy link
Member Author

lol, felt a little too easy -- I wondered what the deal was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants