Only use strings.h when not targeting Win32 #2420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadenf
force-pushed
the
fix-windows
branch
2 times, most recently
from
d2efb71
to
9b5936d
Compare
interwq
reviewed
May 1, 2023
| @@ -2,7 +2,11 @@ | |||
| #include <stdbool.h> | |||
| #include <stdint.h> | |||
| #include <limits.h> | |||
| #include <strings.h> | |||
| #ifdef _WIN32 | |||
| # include "msvc_compat/strings.h" | |||
There was a problem hiding this comment.
We have this include here: https://github.com/jemalloc/jemalloc/blob/dev/include/jemalloc/internal/jemalloc_internal_decls.h#L8
Shouldn't this be covered with that? Sorry I don't have the platform you are using so can't try it myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting Win32, msvc_compat/strings.h should be used instead of strings.h.
Without this PR getting this error when compiling using NodeJS gyp build: