Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only text nodes for TOC #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use only text nodes for TOC #92

wants to merge 3 commits into from

Conversation

jnooree
Copy link
Contributor

@jnooree jnooree commented Jul 9, 2022 •
edited

Current implementation of TOC use full textContent. However, if a heading contains a footnote, the textContent will include the footnote index.

This PR sidesteps such issue by excluding nodes with role === "doc-noteref".

@jeffreytse jeffreytse self-assigned this Jul 25, 2022
@jeffreytse jeffreytse added the enhancement New feature or request label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeffreytse jeffreytse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnooree @jeffreytse