Awilix V6 #272
Merged
Awilix V6 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to resolve any confusion as to what we are checking existence for. BREAKING CHANGE: This is changing the public API.
* Uses a recursive lookup to get the registration being resolved rather than doing a full copy of the registrations. This improves resolve performance by up to 1,000x in some cases * Add `getRegistration` to container Closes #270
BREAKING CHANGE: This breaks consumers that rely on the existing behavior where if a constructor was defined but with no parameters, the base class was parsed. Closes #198.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next major version of Awilix is here, sporting a significant performance increase in some cases for
container.resolveas well as a long-requested change to how dependencies for derived classes are resolved.Closes #270, #198
/cc @code-ape @harindaka @linusnorton @bosconian-dynamics @udnes99