Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat added office depot store #95

Closed
wants to merge 5 commits into from
Closed

feat added office depot store #95

wants to merge 5 commits into from

Conversation

aitaDev
Copy link

@aitaDev aitaDev commented Sep 20, 2020

Description

added store to list and created ts store file, also added more cards for newegg from issue #93

Testing

this ran for half hour only looping store alone with no false positives. changed out of stock to other text which triggered positive

New dependencies

@aitaDev
Update newegg.ts
338c078 
added cards missing from issue jef#93
@aitaDev
Update index.ts
7e4e94c 
added office depot to list
@aitaDev
Create officedepot.ts
4adac91 
created store ts file. Populated cards
@aitaDev aitaDev requested a review from jef as a code owner September 20, 2020 07:52
jef
jef requested changes Sep 21, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Office Depot was added here #157. NewEgg links look good though. If you resolve the conflicts, we can get them in.

Thanks!

@aitaDev aitaDev closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aitaDev @jef