feat: support for smtp server #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
requested changes
Oct 5, 2020
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
|
Once conflicts are resolved, would love to have this in! Thanks for working on this and the previous proxy work. |
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
|
no problem @jef my pleasure. let me know if there is any other action items on my end |
|
@jef and @andrewmackrodt I am going to close this PR and submit a new one as I am noticing that there are alot of conflicts not related to my feature. I will sync my fork then re-add the feature code and generate a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No issue associated with this feature but could be a solution for #370
The proposed change allows the user to specify an
smtp serverip address or fqdn and port in the.envfile to use for sending email and sms notifications. In my particular situation, the application resides behind a proxy server which does not allow connections to external smtp servers but I do have a local mail relay agent available for sending emails.Testing
When
SMTP_ADDRESSandSMTP_PORTare left unspecified the application will use the defaultgmailservice and works as normal. When the mentioned variables are set then the application will use the specified settings to connect to an SMTP Relay Agent and send emails. Both of the previously mentioned cases were tested using the availabletest:notificationnpm scriptand I also set thePHONE_NUMBERandPHONE_CARRIERvariables in order to confirm that SMS notifications worked as well. All tests succeeded.