Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add amazon-uk store with 3080 cards #449

Closed
wants to merge 4 commits into from

Conversation

MrAlexWeber
Copy link

Description

Fixes #357

I tried to base this on @andrewmackrodt's branch but he added a new function for getting new cards (see main...andrewmackrodt:develop#diff-f41e9d04a45c83f3b6f6e630f10117fe) so I ended up basing it on the Amazon-DE store.

Definitely inspired by hacktoberfest 馃巸

Testing

  • I ran npm run lint and it passed the linter
  • I edited my .env to use STORES="amazon-uk"
  • I ran the bot with npm run start:dev and it seemed to be working!

@MrAlexWeber MrAlexWeber requested a review from jef as a code owner October 4, 2020 19:30
@jef
Copy link
Owner

jef commented Oct 5, 2020

Going to close in favor of #455. Sorry 馃槩 Thanks for bring this in though!

@jef jef closed this Oct 5, 2020
@jef
Copy link
Owner

jef commented Oct 5, 2020

Feel free to contribute anything else! Take a look at the issues and see if you can get any hacktoberfest spirit in you 馃巸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to add amazon.co.uk as an option to check?
3 participants