Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): discord false triggers #346

Merged
merged 1 commit into from
Sep 27, 2020
Merged

fix(notification): discord false triggers #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/notification/notification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function sendNotification(link: Link, store: Store) {
sendDesktopNotification(link, store);
}

if (notifications.discord.webHookUrl) {
if (notifications.discord.webHookUrl.length > 0) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... Oops. Happened when I changed this to be lists. I'll start just putting up PRs now since we've grown quite a bit.

Thanks for catching this!

Logger.debug('↗ sending discord message');
sendDiscordMessage(link, store);
}
Expand Down