Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(galaxus): update selector, add out of stock check #1607

Merged
merged 18 commits into from
Jan 11, 2021
Merged

feat(galaxus): update selector, add out of stock check #1607

Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6e558db
Update mediamarkt.ts
wofnull Dec 29, 2020
b7c184a
Updated saturn.ts together with mediamarkt.ts
wofnull Dec 29, 2020
9316271
Bugfix Galaxus, updated to .ZZf1 from old entry
wofnull Dec 31, 2020
91e90d3
Merge remote-tracking branch 'origin/Bugfix_galaxus' into main
wofnull Dec 31, 2020
50021d0
fix: Galaxus again changed the CSS marker for the product_details cha…
wofnull Jan 1, 2021
b55678e
Merge branch 'Bugfix_galaxus_01.01.2020' into main
wofnull Jan 1, 2021
ccad26a
Merge remote-tracking branch 'upstream/main' into main
wofnull Jan 3, 2021
57ca268
Merge remote-tracking branch 'upstream/main' into main
wofnull Jan 5, 2021
d8e75d5
Merge branch 'main-upstream' into main
wofnull Jan 5, 2021
11597f5
Merge branch 'main-upstream' into main
wofnull Jan 6, 2021
b018ebf
fix(store): Update Marker Change 06.01.2021
wofnull Jan 6, 2021
d19b6d6
Galaxus changed the update selector the second time today: now it is …
wofnull Jan 6, 2021
8c2b802
Another change ( 08.01.2021 ) -> Z1fe
wofnull Jan 8, 2021
f649761
Merge branch 'main-upstream' into Galaxus_06.01.2021_Patch
wofnull Jan 11, 2021
5cf7b86
added out of stock check, since stock check seems to fail on all gala…
wofnull Jan 11, 2021
b5cf6ae
Github build and lint cleanup
wofnull Jan 11, 2021
fd1269b
Github build and lint cleanup
wofnull Jan 11, 2021
7408b5e
Change update selector to Z1et ( change today 15:00 GMT )
wofnull Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/store/model/galaxus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const Galaxus: Store = {
text: ['In den Warenkorb']
},
maxPrice: {
container: '.productDetail .Z1ex',
container: '.productDetail .Z1f2',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so after this being dynamic, I think we need another way to solve this as the updated selector no longer works either.

image

Let's see if we can come up with something else.

It seems that using just .productDetail works here. Do you want to test and update?

Thanks!

Copy link
Contributor Author

@wofnull wofnull Jan 7, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using only ".productDetail" works most parts, since i have some special trackings on the galaxus site aswell, i found that as soon that a number comes before the acutal price, the script takes that number (even if it s an percentage)

Example: https://www.galaxus.de/de/s1/product/lian-li-o11dynamic-xl-midi-tower-pc-gehaeuse-12200197
image
image
image
image

So it looks like it works until there is running something like a discount or something like this ( in this case )

If this does not matter at all ( since main purpose is to find stock of items / prices of items overpriced ) i can do push the change to the fix branch if needed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found that as soon that a number comes before the acutal price, the script takes that number (even if it s an percentage)

Well that sucks 😞

Also, updated selector again:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already updated like 10 minutes ago in bugfix branch, should be up to date now ( until the next change i think on sunday / monday ) ...

euroFormat: true
}
},
Expand Down