fix(config): MAX_PRICE quotations
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jef When my discord alerts started pinging hard I thought I was about to get a new card!.. then realizing it was amazon scalper cards well over my price limit, I knew something was wrong 😠 Honestly I don't even know how to produce those curly quotes directly, so not sure how those sneaky little chars really made their way into .env-example... anyhow, easy fix, but feel responsible for that getting out into the wild 🤷♂️ btw congrats on your 3080 🏆 😄 |
|
Thanks for being so thorough on your description and debugging. I appreciate it ❤️ |
jef
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix: Incorrect quotations used in .env-example for MAX_PRICE
Description
Fixes #428
bug fixing an oops 😨... previous merge of #383 had contained an error within .env-example.
Abnormal quotations somehow snuck in with the MAX_PRICE default.
Testing
Testing with a clean clone of the newly merged commit caused price checking to fail.
Discovered the abnormal quotation marks within .env-example
Updated quotations for MAX_PRICE="" and now working again.
🤷♂️