Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psa: MAX_PRICE default in .env-example uses incorrect quotation marks #428

Closed
xninjax opened this issue Oct 2, 2020 · 1 comment · Fixed by #426
Closed

psa: MAX_PRICE default in .env-example uses incorrect quotation marks #428

xninjax opened this issue Oct 2, 2020 · 1 comment · Fixed by #426
Assignees
@jef
Labels
type: bug

Comments

@xninjax
Copy link
Contributor

xninjax commented Oct 2, 2020

Description

For those wanting to use MAX_PRICE feature [commit feat: max price filtering (#383)]

The following line in .env-example uses the incorrect quotation marks (curly quotes)

MAX_PRICE=“”

Please change this line to use normal quotes (straight quotes) around your supplied price

MAX_PRICE=""

eg. MAX_PRICE="1200"

Solution

Pull #426 will fix this in the repository
@jef
Copy link
Owner

jef commented Oct 3, 2020

Fixed! Thanks @xninjax ❤️

@jef jef closed this as completed Oct 3, 2020
@jef jef mentioned this issue Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jef jef

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(config): MAX_PRICE quotations
2 participants
@jef @xninjax