feat(store): add newegg.ca #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcsabbagh
reviewed
Sep 21, 2020
I believe I updated the readme to include newegg.ca |
|
@xdMatthewbx since you are already in the |
Oh I'm stupid disregard my comment 🤦 |
|
Resolves #159 as a stop-gap until locales are implemented. |
Closed
jef
approved these changes
Sep 21, 2020
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds newegg.ca to supported stores
Discord is xdMatthewbx#1337
Testing
Tested running with
newegg-caadded to stores list and am not encountering errors. Additionally stock alerts appear to be functioning but that may not be the case as none have actually come in stock yet.