Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newegg.ca #159

Closed
Nolij opened this issue Sep 21, 2020 · 3 comments
Closed

Newegg.ca #159

Nolij opened this issue Sep 21, 2020 · 3 comments
Assignees
@jef

Comments

@Nolij
Copy link
Contributor

Nolij commented Sep 21, 2020

Add newegg.ca to websites as it appears to have separate stock (correct me if I'm wrong).
@ultimateguy
Copy link

Seconded. I would add bestbuy.ca as well.

@geman220
Copy link
Contributor

geman220 commented Sep 21, 2020 •
edited

We are working on locale .env variables now starting with Nvidia and then rolling to other sites after that. Currently, we would have to create a new store .ts for every single locale (so newegg.com.ts newegg.ca.ts etc). Locales will make it possible to define in .env and then have a single newegg.ts that modifies the URLs searched based on locale (as well as language for non-English stores). This enhancement may not get addressed until that is implemented (but is in work now). Not sure what @jef thinks about it though.

@geman220 geman220 mentioned this issue Sep 21, 2020
Merged
@geman220
Copy link
Contributor

I just noticed you have PR #160 in so that could work as a stop-gap until locales are implemented

@jef jef closed this as completed in 76f5849 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jef jef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jef @ultimateguy @Nolij @geman220