Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): prevent filename collision #429

Merged
merged 5 commits into from May 18, 2024
Merged

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans commented May 10, 2024

Apparently, ManimCE can produce two different animations with the same name (i.e., the same hash). As documented, ManimGL would anyway produce files with the same name, so this fix was needed.

Closes #428

Apparently, ManimCE can produce two different animations with the same name (i.e., the same hash). As documented, ManimGL would any produce files with the same name so this fix was needed.

Closes #428
@jeertmans jeertmans added bug Something isn't working html-convert Related to converting to HTML slides labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (962ff2b) to head (818f66b).
Report is 1 commits behind head on main.

Current head 818f66b differs from pull request most recent head 19c74f6

Please upload reports for the commit 19c74f6 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   79.33%   79.30%   -0.04%     
==========================================
  Files          22       22              
  Lines        1815     1822       +7     
==========================================
+ Hits         1440     1445       +5     
- Misses        375      377       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chore(lib): update comment
@jeertmans jeertmans merged commit b080739 into main May 18, 2024
9 of 13 checks passed
@jeertmans jeertmans deleted the fix-filename-collision branch May 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html-convert Related to converting to HTML slides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Slides are shuffled when exporting mutliple files to revealjs format
1 participant