Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a configurable log level #20

Merged
merged 8 commits into from Feb 5, 2022
Merged

Allow a configurable log level #20

merged 8 commits into from Feb 5, 2022

Conversation

michaelkrieger
Copy link
Contributor

Currently there is no way to override the log level from the default.

Note: I could have used LOGLEVEL="${LOGLEVEL:-info}", but in case the shell isn't (always) bash, this is more compatible.

jee-r and others added 5 commits October 17, 2021 02:54
- from emmercm/libtorrent:1.2.14-libtorrent
- github action
Note: I could have used LOGLEVEL="${LOGLEVEL:-info}", but in case the shell isn't (always) bash, this is more compatible.
@jee-r
Copy link
Owner

jee-r commented Dec 19, 2021

Hi @michaelkrieger thank's for your pull request

LOGLEVEL="${LOGLEVEL:-info}" could be a cleaner solution may be we should force bash as the default shell considering that bash is installed by default

bash \

It's look like we have 2 solutions to set bash as the default SHELL

using ENV :

ENV SHELL /bin/bash

or using SHELL
https://docs.docker.com/engine/reference/builder/#shell
moby/moby#7281 (comment)

SHELL ["/bin/bash", "-c"]

I don't know what is the best approach

@jee-r jee-r changed the base branch from master to dev February 5, 2022 10:22
@jee-r jee-r merged commit 5c9cc05 into jee-r:dev Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants