New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC9381 ECVRF implementation #1188

Open

iquerejeta wants to merge 11 commits into jedisct1:master from iquerejeta:vrf_version_12

+821 −88

iquerejeta commented Jun 14, 2022 •

edited

Implementation of RFC9381.

Made a change to ed25519_ref10 for performance reasons. Mainly, I have included a variable base variable time scalar multiplication (to compute a * U + b * V for variable U and V).

Implements #1177

sonatype-lift bot reviewed

View reviewed changes

src/libsodium/crypto_vrf/crypto_vrf.c Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

test/default/vrf.c Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

test/default/vrf Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

src/libsodium/include/sodium/private/ed25519_ref10.h Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

src/libsodium/crypto_vrf/ietfdraft12/keypair.c Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

src/libsodium/crypto_vrf/ietfdraft12/verify.c Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

src/libsodium/crypto_vrf/ietfdraft12/vrf_ietfdraft12.h Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

test/default/vrf.c Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

test/default/vrf.c Outdated Show resolved Hide resolved

jedisct1 reviewed

View reviewed changes

src/libsodium/crypto_vrf/ietfdraft12/verify.c Outdated Show resolved Hide resolved

jedisct1 force-pushed the master branch 4 times, most recently from 82c35a0 to 6d1d7ed Compare

November 14, 2022 21:16

thecontemoraryflorals approved these changes

View reviewed changes

thecontemoraryflorals approved these changes

View reviewed changes

jedisct1 requested review from thecontemoraryflorals and removed request for thecontemoraryflorals

December 25, 2022 16:37

jedisct1 marked this pull request as draft

December 25, 2022 16:41

gitmachtl mentioned this pull request

Algorand/IOG libsodium VRF implementation for node js? jedisct1/libsodium.js#314

Closed

Owner

jedisct1 commented Aug 23, 2023

https://www.rfc-editor.org/rfc/rfc9381.pdf

Author

iquerejeta commented Aug 29, 2023

@jedisct1 , does this mean that we are good to push this forward? If yes, I'll make a pass to make sure that the implemented version is what got finalised in the draft, and mark it as ready.

Owner

jedisct1 commented Aug 29, 2023

@iquerejeta Yes :)

iquerejeta force-pushed the vrf_version_12 branch from a57cada to fae333b Compare

September 6, 2023 08:26

iquerejeta marked this pull request as ready for review

September 6, 2023 09:09

iquerejeta requested a review from jedisct1

September 6, 2023 09:09

jedisct1 force-pushed the master branch 3 times, most recently from 59beda3 to 9db7738 Compare

September 10, 2023 23:50


          Version 12 of ECVRF

b7a185f

iquerejeta added 8 commits

September 11, 2023 08:44


          Incorrect ordering of function inputs

fe70cb9


          Identation and notation

ae3500e


          single multiscalar multiplication function

44dcadc

Also changed the style of tests, where the expected output is in vrf.exp rather than in test data (following the style of the hashing).


          declarations inside the if code block

522fc97


          identation of test_data

f457de1


          Rename to RFC9381

606d1bd


          Move declarations to top of block

84ae555


          Check small order over deserialised PK

9d834f7

iquerejeta force-pushed the vrf_version_12 branch from 939466b to 9d834f7 Compare

September 11, 2023 07:16

Author

iquerejeta commented Sep 11, 2023 •

edited

Got some trouble reproducing the undefined reference to 'crypto_core_ed25519_scalar_negate' and undefined reference to 'crypto_core_ed25519_scalar_negate' errors locally. I made sure I was configuring with the same call as the CI action:

env CPPFLAGS="-DDEV_MODE=1" ./configure --disable-dependency-tracking --enable-minimal

But couldn't reproduce it.

This is the failing action https://github.com/jedisct1/libsodium/actions/runs/6095043654

jedisct1 force-pushed the master branch 6 times, most recently from 7d794f1 to e15f2f7 Compare

September 11, 2023 09:43

Author

iquerejeta commented Sep 11, 2023

So, I've managed to reproduce them, but no progress in debugging. I'll try again tomorrow. Any idea why we might have

Undefined symbols for architecture arm64:
...
ld: symbol(s) not found for architecture arm64

type errors for symbols that are exposed in the public API when called within the library?

Owner

jedisct1 commented Sep 11, 2023

Errrrr... this is super weird.

How did you manage to reproduce it? Is it non-deterministic?

Owner

jedisct1 commented Sep 11, 2023

Actually it's not weird.

The core_ed25519 functions are not available in MINIMAL builds.

Author

iquerejeta commented Sep 12, 2023

Ok, makes sense. What is your preferred way forward? To have core_ed25519 exposed in the MINIMAL build, or instead have from_string and scalar_negate as part of ed25519_ref10.c? Seeing how the library is organised, I presume the second, but just want to check with you before making further changes.

Owner

jedisct1 commented Sep 12, 2023

Yeah, I agree that the second option looks better.


          Include from_string functions in ed25519_ref10

7846afb

jedisct1 force-pushed the master branch from 20248b8 to f26b9f7 Compare

September 13, 2023 06:59


          Update quirks.h

05d0984

iquerejeta changed the title ~~Version 12 of ECVRF draft~~ RFC9381 ECVRF implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment