This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Make paths absolute when using compile_commands.json file #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: caozhong <zhong.z.cao@intel.com>
jeaye
reviewed
May 16, 2021
include/conf/load.hpp
Outdated
| @@ -41,6 +41,20 @@ namespace color_coded | |||
|
|
|||
| return line; | |||
| } | |||
|
|
|||
| void make_absolute(std::string &line, std::string &next, const fs::path &base) { | |||
There was a problem hiding this comment.
Since make_absolute makes a lot of assumptions about the data it's working with, with both line and next and their relationship, I think it'd be a cleaner approach to just have make_absolute work with the whole range. i.e.
template <typename It>
void make_absolute(It const &begin, It const &end, fs::path const &base)There was a problem hiding this comment.
I'm not sure I followed, make_absolute line/next is for the case where:
-I | -isystem | ...
../some/path/to/include
You mean there would be a case where:
-I | -isystem | ...
<empty line>
<empty line>
../some/path/to/include
Or just a single API make all directories absolute.
| } else { | ||
| line = make_absolute(line, base); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Will you please update the braces and const positioning to match the rest of the file? We use Allman-like braces, with a one-line exception, and const always goes to the right. You can find examples of each of these within this file.
…on file Signed-off-by: caozhong <zhong.z.cao@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Also add a searching directory for lua library. @jeaye