Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-package.yml #46

Merged
merged 1 commit into from May 11, 2024
Merged

Update python-package.yml #46

merged 1 commit into from May 11, 2024

Conversation

jdtuck
Copy link
Owner

@jdtuck jdtuck commented May 11, 2024

No description provided.

@jdtuck jdtuck merged commit 6a60942 into master May 11, 2024
13 checks passed
@vnmabus
Copy link
Contributor

vnmabus commented May 12, 2024

From this PR I guess that you, @jdtuck, found an identical problem as mine and your CI is failing in MacOS.

In my case, I am executing pip install mkl-devel, as you suggested before. Now, it tries to install an older version of mkl-devel (it only considers 2018.0.0 and 2018.0.3 as candidates), and it is not able to resolve them. However, on the 24th of April the CI on MacOS was just fine, and it installed mkl-devel in version 2023.2.1. The next CI two days later failed. I guess that version 2023.2.2 released on 25th April may have something to do with it. Do you know what is the problem?

I also wanted to ask if you considered the proposal in david-cortes/findblas#3 (comment) to use SciPy machinery to find BLAS, or any other alternative so that I don't have to install mkl-devel manually (maybe you can upload wheel binaries using Github actions?).

@jdtuck
Copy link
Owner Author

jdtuck commented May 12, 2024

I did on the CI, but not on my local Mac. I don’t think anything is wrong with mkl-devel on pip, but the old version of python < 3.9 being used on the CI and compatibility.

I did look at the proposal and I could not get it to work, if you would like to try it and see if I missed something, that would be great. I have uploaded binaries before recently, but the all the combinations it was struggling with. The problem is base python struggles when cython calls c++ that relies on BLAS. The new optimization routine uses BLAS and is much faster and I do not want to remove it from the package.

@jdtuck jdtuck deleted the jdtuck-patch-1 branch May 20, 2024 21:33
@vnmabus
Copy link
Contributor

vnmabus commented May 25, 2024

I asked Intel. They refuse to support any version older than 2024.0 and they have removed MacOS support in recent versions. I still don't know if they are actively removing oldest ones or why it does suddenly not work, but we should use anything else than MKL for MacOS. Do you know if there is an alternative that just works everywhere, in order to fix my CI?

@jdtuck
Copy link
Owner Author

jdtuck commented May 25, 2024

Not yet, I am working on a solution, but haven't found one yet.

@jdtuck
Copy link
Owner Author

jdtuck commented May 25, 2024

I have a fix in for findblas to find openblas installed via homebrew on mac.

david-cortes/findblas#8

After that is approved and a new release to pip, all we need to do is a brew install openblas for the runner and it should work. I have tested this locally on my mac.

@jdtuck
Copy link
Owner Author

jdtuck commented May 25, 2024

Moving this to #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants