Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-29177: add RSP feature in site #802

Merged
merged 1 commit into from
Apr 22, 2024
Merged

JBIDE-29177: add RSP feature in site #802

merged 1 commit into from
Apr 22, 2024

Conversation

sbouchet
Copy link
Contributor

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@sbouchet
JBIDE-29177: add RSP feature in site
3ed41d0 
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
@sbouchet sbouchet merged commit 3ed41d0 into main Apr 22, 2024
2 of 4 checks passed
@sbouchet sbouchet deleted the JBIDE-29177 branch April 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robstryker robstryker Awaiting requested review from robstryker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sbouchet