Fixes #799 - add rsp server feature #800
Conversation
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net> Cleanup pt 2 Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
|
first comment about general usage of the view. below is the some screenshots of my tests. |
those are ok. |
|
here the list is cropped at the very end. |
|
is the secure storage pop pu is mandatory ? the text box is too short, please use all the space. |
|
those two have some background issues and labels are not centered with the text boxes. |
| @@ -0,0 +1,28 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2010-2012 Red Hat, Inc. and others. | |||
There was a problem hiding this comment.
as it's new fil, i would assume it should be year 2023.
| <artifactItem> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>2.10.1</version> |
There was a problem hiding this comment.
there is already a gson bundle in the tp : https://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.28.0.Final-SNAPSHOT/REPO/plugins/com.google.gson_2.10.1.v20230109-0753.jar
| super.start(context); | ||
| plugin = this; | ||
|
|
||
| // newServerEventType = new UsageEventType(USAGE_COMPONENT_NAME, UsageEventType.getVersion(ASWTPToolsPlugin.this), |
There was a problem hiding this comment.
please enable those metrics events, it will be available in amplitude for a future chart.
| main.setLayoutData(new GridData(GridData.FILL_BOTH)); | ||
| main.setLayout(new FormLayout()); | ||
| createUI(main); | ||
| // setMessage(info.description != null ? info.description |
There was a problem hiding this comment.
remove these comments if not necessary
| } | ||
|
|
||
| private void createUI(Composite main) { | ||
| // TODO Auto-generated method stub |
| } | ||
|
|
||
| public void fillActionBars() { | ||
| // getViewSite().getActionBars().getToolBarManager().add(new NewConnectionAction()); |
There was a problem hiding this comment.
please remove if not necessary
| @Override | ||
| public void modelChanged(Object item) { | ||
| Display.getDefault().asyncExec(() -> { | ||
| // System.out.println("Refreshing " + item); |
| try { | ||
| return new String(Files.readAllBytes(filePath)); | ||
| } catch (IOException e) { | ||
| // TODO log error |
There was a problem hiding this comment.
please use below logger facility to log error.
| @@ -0,0 +1,72 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2020 Red Hat, Inc. | |||
I'll try to use all the space. Whether this specific prompt is necessary is more a question about the underlying RPS. The UI is just responding to a request for prompt from the background RSP and must display it. |
Looks fine in light mode, but not dark mode. Wonder what's wrong here. |
Seems the styling matches on class names somehow, and extending "Composite" is frowned upon. Converting my composite subclasses to just be a kind of wrapper instead seems to fix it. |
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Pull Request Checklist
General
Code
Testing
Function