Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes JBIDE-28927 - missing web fragment facet for eap8 #798

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fixes JBIDE-28927 - missing web fragment facet for eap8 #798

merged 2 commits into from
Jul 14, 2023

Conversation

robstryker
Copy link
Member

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@robstryker
Fixes JBIDE-28927 - missing web fragment facet for eap8
41d0004 
Signed-off-by: Rob Stryker <rob@oxbeef.net>
@robstryker
Copy link
Member Author

webfragment was overlooked for eap. Changes were made only to the web facet, no the web fragment facet.

@robstryker
Upversion as to 3.10.3
281f33c 
Signed-off-by: Rob Stryker <rob@oxbeef.net>

Upversion as to 3.10.3

Signed-off-by: Rob Stryker <rob@oxbeef.net>
@robstryker robstryker merged commit 4d8a5bb into jbosstools:main Jul 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robstryker