Join XP and EAP branch and add support for XP JDK17 no SSO #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
reviewed
Apr 4, 2023
| @@ -6,6 +6,22 @@ execute: | |||
| - script: configure.sh | |||
| user: '185' | |||
|
|
|||
| envs: | |||
| - name: LD_PRELOAD | |||
There was a problem hiding this comment.
These env seem a duplicate of the one in https://github.com/jboss-container-images/jboss-eap-modules/blob/master/jboss/container/eap/launch/common/module.yaml#L10
And this module depends on jboss.container.eap.launch.common so the env can be removed.
|
@rdnovell , these changes look fine to me. The only thing we don't know yet is if we will have support for SSO for the XP4 on JDK17 image. |
rdnovell
changed the title
xstefank
approved these changes
Apr 20, 2023
|
@jfdenise Can you review the latest changes? |
jfdenise
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/CLOUD-4168
Signed-off-by: Ruben Dario Novelli rnovelli@redhat.com