fixed DeprecationWarning

[uri-rodberg]

fixed DeprecationWarning

Fixes #727

[codecov]

Codecov Report

Merging #739 (2a8b071) into master (eb2420d) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   74.11%   74.11%           
=======================================
  Files          30       30           
  Lines        1700     1700           
=======================================
  Hits         1260     1260           
  Misses        440      440           

Files Changed	Coverage Δ
sorl/__init__.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[uri-rodberg]

Can you please review this PR?

[claudep]

It's not very nice to merge such pull requests and pollute the master git history with 12 commits to only change one file. Please next time, at least squash the commits when merging, as long as the individual commits do not make sense to figure by themselves in the main history.

[uri-rodberg]

It's not very nice to merge such pull requests and pollute the master git history with 12 commits to only change one file. Please next time, at least squash the commits when merging, as long as the individual commits do not make sense to figure by themselves in the main history.

OK, next time. Let me know if you want to revert this time.

[claudep]

No need to revert, just take care in the future. Ideally, each commit in a good git history should pass the test suite. It's not just nit-picking, it has a real value when for example you want to git bisect a repo.