-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add Python 3.4 and 3.5 definitions #612
Conversation
Line 25 in 8673a91
|
f7d98fa
to
87a71e8
Compare
Thanks @jezdez - I absolutely missed that! |
87a71e8
to
7204691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to support 3.4 and 3.5 it's good to have them in the Travis and tox test matrix as well :)
@aleksihakli I've used the PR description from #610 in the changelog to state that these versions are deprecated. |
Ah, that seems good! The codebase didn't change anyways so things should ideally be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
By the way, merging this and making a new release on GitHub tag GUI from master should now push the changes to the Jazzband PyPI server after a successful build. From there they can be then released to public PyPI :) |
@camilonova @aleksihakli - I'm not a band member (might be some day) - but I can vouch for a 12.6.1 tag :) |
@camilonova I added a 12.6.1 tag, would you like to make a new release? That should fix #607 as well. @jezdez I can also help maintain the project and make new releases through the Jazzband site if @camilonova and the existing contributors are OK with that. |
@aleksihakli please do. I'm happy to bring you in. Go ahead and make the 12.6.1 release |
@camilonova I don't have the permissions to the project, so it would be great if you could make the release through the Jazzband site to PyPI! |
I've tried and got this:
|
@camilonova this was probably caused by a rST syntax error in the README.rst, merging #613 should help. We can bake a 12.6.2 release from that after upstreaming. I'll add a rST validator step into the CI pipeline. |
@aleksihakli just merged #613 let's go for a release |
Suggesting to merge this and tag 12.6.1
CC: @aleksihakli @camilonova @jezdez