Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Python 3.4 and 3.5 definitions #612

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jan 23, 2020

Suggesting to merge this and tag 12.6.1

CC: @aleksihakli @camilonova @jezdez

@jezdez
Copy link
Member

jezdez commented Jan 23, 2020

python_requires='>=3.6',
needs to be defused a bit for this to work.

@coveralls
Copy link

coveralls commented Jan 23, 2020

Coverage Status

Coverage remained the same at ?% when pulling 7204691 on benjaoming:12.6.1-release into 8673a91 on jazzband:master.

@benjaoming
Copy link
Contributor Author

Thanks @jezdez - I absolutely missed that!

Copy link
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to support 3.4 and 3.5 it's good to have them in the Travis and tox test matrix as well :)

@benjaoming
Copy link
Contributor Author

If you want to support 3.4 and 3.5 it's good to have them in the Travis and tox test matrix as well :)

@aleksihakli I've used the PR description from #610 in the changelog to state that these versions are deprecated.

@aleksihakli
Copy link
Member

Ah, that seems good! The codebase didn't change anyways so things should ideally be good to go.

Copy link
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aleksihakli
Copy link
Member

By the way, merging this and making a new release on GitHub tag GUI from master should now push the changes to the Jazzband PyPI server after a successful build. From there they can be then released to public PyPI :)

@aleksihakli aleksihakli merged commit 69ca2dc into jazzband:master Jan 26, 2020
@benjaoming
Copy link
Contributor Author

@camilonova @aleksihakli - I'm not a band member (might be some day) - but I can vouch for a 12.6.1 tag :)

@aleksihakli
Copy link
Member

aleksihakli commented Jan 27, 2020

@camilonova I added a 12.6.1 tag, would you like to make a new release? That should fix #607 as well.

@jezdez I can also help maintain the project and make new releases through the Jazzband site if @camilonova and the existing contributors are OK with that.

@camilonova
Copy link
Member

@aleksihakli please do. I'm happy to bring you in. Go ahead and make the 12.6.1 release

@aleksihakli
Copy link
Member

@camilonova I don't have the permissions to the project, so it would be great if you could make the release through the Jazzband site to PyPI!

@camilonova
Copy link
Member

I've tried and got this:

Standard error

HTTPError: 400 Client Error: The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information. for url: https://upload.pypi.org/legacy/

@camilonova camilonova assigned camilonova and unassigned camilonova Jan 28, 2020
@aleksihakli
Copy link
Member

@camilonova this was probably caused by a rST syntax error in the README.rst, merging #613 should help. We can bake a 12.6.2 release from that after upstreaming. I'll add a rST validator step into the CI pipeline.

@camilonova
Copy link
Member

@aleksihakli just merged #613 let's go for a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants