Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new search function #117

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

new search function #117

wants to merge 6 commits into from

Conversation

372798735
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for githubrank ready!

Name Link
🔨 Latest commit fa68d7f
🔍 Latest deploy log https://app.netlify.com/sites/githubrank/deploys/66235f5da290a600081dea2b
😎 Deploy Preview https://deploy-preview-117--githubrank.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaywcjlove
Copy link
Owner

image

@372798735 Thank you for your PR, but I think the browser's built-in search function is sufficient.

@372798735
Copy link
Contributor Author

372798735 commented Apr 19, 2024 via email

README-zh.md Outdated
Comment on lines 31 to 44
## 克隆项目

```bash
git clone https://github.com/372798735/github-rank-fork.git
```
```bash
cd github-rank-fork

npm install
```
run
```bash
npm run start
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-rank/README-zh.md

Lines 91 to 114 in 303bad1

## 开发
```bash
$ git clone https://github.com/jaywcjlove/github-rank.git
$ cd github-rank
$ npm install # 安装依赖
$ npm run build # 编译输出脚本
```
获取数据
```bash
$ npm run get:trending # 获取 trending 数据
$ npm run get:repos # 获取 repos 数据
$ npm run get:users # 获取 users 数据
$ npm run get:users:china # 获取 users(china) 数据
```
生成 HTML 页面
```bash
$ npm run start
```

The content is redundant with the following.

README.md Outdated
run
```bash
npm run start
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-rank/README-zh.md

Lines 91 to 114 in 303bad1

## 开发
```bash
$ git clone https://github.com/jaywcjlove/github-rank.git
$ cd github-rank
$ npm install # 安装依赖
$ npm run build # 编译输出脚本
```
获取数据
```bash
$ npm run get:trending # 获取 trending 数据
$ npm run get:repos # 获取 repos 数据
$ npm run get:users # 获取 users 数据
$ npm run get:users:china # 获取 users(china) 数据
```
生成 HTML 页面
```bash
$ npm run start
```

The content is redundant with the following.

@jaywcjlove
Copy link
Owner

@372798735 I think calling this feature 'filtering' is appropriate. I believe we can merge it, but there's a bug in the functionality: the sorting feature for 'followers' and 'following' is not working.

image

@372798735
Copy link
Contributor Author

Okay, I'll fix it tonight

@jaywcjlove
Copy link
Owner

@372798735 I tested it and the clicks still don't sort.

@372798735
Copy link
Contributor Author

@372798735 I tested it and the clicks still don't sort.
I'm not sure. follows are sorted。
Uploading Snipaste_2024-04-26_22-36-57.png…

@372798735
Copy link
Contributor Author

Snipaste_2024-04-26_22-36-57

@jaywcjlove
Copy link
Owner

@372798735 I tested locally, but the sorting still doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants