Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes (Python version and Python tests) #295

Merged
merged 3 commits into from Dec 19, 2023

Conversation

MarcBerneman
Copy link
Contributor

Updated Python versions because Haiku does not support Python 3.8 anymore (google-deepmind/dm-haiku@26de2c0).

FLAGS = jax_config.FLAGS gives an error (see action):
AttributeError: ''Config' object has no attribute 'FLAGS'
This has been fixed by replacing FLAGS.jax_enable_x64 by jax_config.jax_enable_x64

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e107c26) 82.78% compared to head (e0f58a5) 82.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          27       27           
  Lines        5245     5245           
=======================================
  Hits         4342     4342           
  Misses        903      903           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschoenholz sschoenholz merged commit a4851b8 into jax-md:main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants