-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simulate.py #179
Open
moyuanchen
wants to merge
9
commits into
jax-md:main
Choose a base branch
from
moyuanchen:bd_improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update simulate.py #179
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ef49125
Update simulate.py
moyuanchen 8b04205
Update simulate.py
moyuanchen d893392
Update simulate.py
moyuanchen f3293ff
Merge branch 'bd_improvement' into bd_improvement_2
moyuanchen a36336d
Merge pull request #1 from moyuanchen/bd_improvement_2
moyuanchen 67c0e6d
Update simulate.py
moyuanchen de8d4fa
Update documentation of mass and gamma
moyuanchen afa2d1b
Update quantity.py
moyuanchen 5e60f3b
Update simulate.py
moyuanchen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to rename this to be something a little bit more descriptive for someone who doesn't know what gamma is? Perhaps something like
spherical_stokes_friction
? This isn't really my area of expertise, so feel free to pick something else!