Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new context api #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use new context api #12

wants to merge 1 commit into from

Conversation

jnsdls
Copy link

@jnsdls jnsdls commented Dec 21, 2018 •
edited

  • updated dependencies
  • bumped required react version
  • used new context api
  • tests are passing
  • no more warnings in <StrictMode/>

@jnsdls
Copy link
Author

jnsdls commented Dec 21, 2018

@javivelasco please have a look when u have a minute and let me know if there's anything you would like me to change

@jgoux
Copy link

jgoux commented Jan 24, 2019

I'd love this PR and the other to get merged. 🙏

@jnsdls
Copy link
Author

jnsdls commented Jan 24, 2019

fwiw I have been using this branch in production ever since creating it and there have been 0 issues so far.

@veeramarni
Copy link

@javivelasco can this PR be merged?

@kiurchv
Copy link

kiurchv commented Jan 13, 2020

@javivelasco More than year passed. Any chance to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jnsdls @jgoux @veeramarni @kiurchv