Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using view as Snackbar container instead android.R.id.content. #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipetorres
Copy link

Using android.R.id.content as container is a problem when working with bottom navigation bar. So, this PR allows to pass a view that will be the snackbar container.

@javiersantos
Copy link
Owner

javiersantos commented Oct 13, 2019

Does this change require to include .setView() when creating an AppUpdater instance? If so, we should update the README or initialize this.view as android.R.id.content. Thanks.

Copy link
Owner

@javiersantos javiersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you initialize this.view as android.R.id.content?

@javiersantos javiersantos self-assigned this Oct 13, 2019
@redragon14368
Copy link

sir, the release note not showing. please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants