Assignment by ganesh khaire #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { Jumbotron } from "react-bootstrap"; | ||
| import { Link } from 'react-router-dom'; | ||
|
|
||
| class Home extends Component { |
There was a problem hiding this comment.
Components that do not have state can be converted to stateless functional components. Detailed explanation here
| class Page404 extends Component { | ||
| render() { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
You can directly return the <Jumbotron> container as done in Home component.
| componentDidMount(){ | ||
| this.getUser(); | ||
| } | ||
| getUser(){ |
There was a problem hiding this comment.
The server related code can be refactored into its own separate 'api' module.
| render() { | ||
| let table = | ||
| this.state.userList.map((user ,i)=>{ | ||
| return ( <TableDataRow data={user} key={i} |
There was a problem hiding this comment.
The component should be written in one single line or into multiple lines as follows for better readability.
<TableDataRow
data={user}
key={i}
delete={this.deleteEntry.bind(this)}
/>
| delete={this.deleteEntry.bind(this)}/> ); | ||
| }); | ||
| return ( | ||
| <Jumbotron > |
| this.setState({ userList: newList }); | ||
| } | ||
| getUseList(){ | ||
| fetch('https://jsonplaceholder.typicode.com/users') |
There was a problem hiding this comment.
Separate the server code into its own 'api' module.
javascripters2015
requested changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.