Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment by shashikant kumar #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Assignment by shashikant kumar #10

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2017

Assignment work done.

Copy link
Contributor

@javascripters2015 javascripters2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README file with setup instructions.
Use comments in code to understand the code implementation intention for any third person.

render() {
return (
<div className="Item">
<img src={this.imageUrl} alt=""/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt tag empty for <img /> tag. [Accessibilty]

2.Added comment
3.Remove unused code
@ghost
Copy link
Author

ghost commented Aug 15, 2017

I have added appropriate comments and updated README file with setup instructions.

@@ -0,0 +1,16 @@
import React, { Component } from 'react';

//import footer css

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code should not be pushed to GitHub.

@@ -1,24 +1,24 @@
import React, { Component } from 'react';

import logo from '../../images/logo.png';
//import header css

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Comment on lines +10 to +14
{/* Header Banner */}
<div className="App-header">
<h2>Welcome to My Hotels</h2>
</div>
{/* Header menu */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants