New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment by shashikant kumar #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README file with setup instructions.
Use comments in code to understand the code implementation intention for any third person.
src/components/Item/Item.js
Outdated
render() { | ||
return ( | ||
<div className="Item"> | ||
<img src={this.imageUrl} alt=""/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alt tag empty for <img />
tag. [Accessibilty]
2.Added comment 3.Remove unused code
I have added appropriate comments and updated README file with setup instructions. |
@@ -0,0 +1,16 @@ | |||
import React, { Component } from 'react'; | |||
|
|||
//import footer css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code should not be pushed to GitHub.
@@ -1,24 +1,24 @@ | |||
import React, { Component } from 'react'; | |||
|
|||
import logo from '../../images/logo.png'; | |||
//import header css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
{/* Header Banner */} | ||
<div className="App-header"> | ||
<h2>Welcome to My Hotels</h2> | ||
</div> | ||
{/* Header menu */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Assignment work done.