New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 2960 #2965
Open
qzchenwl
wants to merge
2
commits into
javaparser:master
Choose a base branch
from
qzchenwl:fix/issue-2960
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix issue 2960 #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the test case:
parsing public <N extends Node> ParseResult<N> parse(ParseStart<N> start, Provider provider) {
try {
final ASTParser parser = getParserForProvider(provider);
N resultNode = start.parse(parser);
final CommentsCollection comments = astParser.getCommentsCollection();
commentsInserter.insertComments(resultNode, comments.copy().getComments());
return new ParseResult<>(Optional.of(resultNode), parser.problems, Optional.of(astParser.getTokens()), Optional.of(astParser.getCommentsCollection()));
} catch (ParseException e) {
return new ParseResult<>(e);
} catch (TokenMgrException e) {
return new ParseResult<>(e);
} finally {
try {
provider.close();
} catch (IOException e) {
// Since we're done parsing and have our result, we don't care about any errors.
}
}
} There are two cases when argument is type variable:
They should be treat differently. Case 1 is a type waitting to be inferred, case 2 is a fixed type. |
This PR seems correct but there are few errors in unit tests. When i try to report your correction on the current version i got this errors.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2960.