job_list self.respond_to? responds to empty @set_variables #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @benlangfeld |
|
I am also affected by the issue @benlangfeld |
trungtran1512
approved these changes
Dec 15, 2022
|
Hello @trungtran1512, do you have any idea about when this PR will be merged and when a new release will be cut? thanks |
|
Hello @crevete, I don't know about this but I tried under local it works fine. |
|
Hello @trungtran1512 who is the maintainer of this project? I guess @benlangfeld? Why he does never respond? Is this project dead? The code base is out-to-date... |
|
I think it shuold be fixed as - def self.respond_to?(name, include_private = false)
+ def respond_to?(name, include_private = false) |
adamrainsby
reviewed
Apr 27, 2023
lib/whenever/job_list.rb
Outdated
| @@ -38,7 +38,9 @@ def method_missing(name, *args, &block) | |||
| end | |||
|
|
|||
| def self.respond_to?(name, include_private = false) | |||
| @set_variables.has_key?(name) || super | |||
| if @set_variables | |||
There was a problem hiding this comment.
This will always be nil so this is effectively just super
Makes sense, I've updated the PR, thanks! |
groyoh
added a commit
to happydemics/whenever
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1.4.3 (ruby/irb@v1.4.3...master), irb ruby gem (https://github.com/ruby/irb) is calling directly "respond_to?" method on all included code inside a project. That change makes all code included in a project having that method crashing if implementing it in a way not always returning a true or false, like described in the ruby doc: https://www.rubydoc.info/stdlib/core/Object:respond_to%3F
So, I just wanted to propose that simple change which would prevent that (and maybe) other situations, now always returning a value. I've not used the Ruby '&' in order to be retro-compatible with pre-2.3 ruby versions, in case.