Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme file in order to add docs for Docker usages #770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kakashysen
Copy link

In order to help people that want to use whenever gem in docker projects I update the readme file with a couple of instructions.

Copy link
Collaborator

@benlangfeld benlangfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very specific to Debian-based base images and does not address how cron might be executed.

Base automatically changed from master to main January 20, 2021 18:17
@@ -301,6 +301,12 @@ This tells rvm to trust all rvmrc files.

No. Heroku does not support cron, instead providing [Heroku Scheduler](https://devcenter.heroku.com/articles/scheduler). If you deploy to Heroku, you should use that rather than Whenever.

### Docker

If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` if not add the following line to you `Dockerfile`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` if not add the following line to you `Dockerfile`
If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` on it.

Comment on lines +307 to +309

`apt-get install -y cron`

Copy link
Contributor

@bragamat bragamat Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`apt-get install -y cron`
NOTE: Check your docker image's OS base (e.g. ubuntu, debian, alpine) to know how to properly install it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants