Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request aborting and schema-relative urls #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

homm
Copy link

@homm homm commented Sep 13, 2013

First about aborting. This is unexplainably magic. I can only suppose what IE require closure in this place. But this is fact: requests with onprogress = $.noop fails in many cases (long request, long response, slow connection).

Schema-relative urls required because «Requests must be targeted to the same scheme as the hosting page» is one of XDomainRequest limitation. As I can see schema-relative urls works fine in this place.

nt3rp added a commit to Willet/SecondFunnel that referenced this pull request Feb 3, 2014
jaubourg/ajaxHooks#5
Also, we're STILL doing this live!
@jaubourg
Copy link
Owner

jaubourg commented Feb 7, 2014

It would be awesome to have at least a test page that can, even randomly, demonstrate the magic in IE is defeated.

As for the scheme-relative URL, not sure I buy the solution here. First, you have many other schemes than /^https?:/. Second, since it's a limit of the implementation, I'd rather have the transport control the scheme and fail the ajax request if the schemes are different.

And, yes, I'm very late to the party but I swear I didn't see this PR before Oo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants