Fail check on non success status code #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if an error makes sense for all non 2** response codes. It seems like we might get non 2** response codes for pages that are still accessible from the browser. For example, On the other hand, it might be better to over-report issues when looking for broken links than to let possible issues go unnoticed. |
If an external link results in a non success status code (for example 404), we now alert the user with an error.
clample
force-pushed
the
link-check-failure-on-non-200
branch
from
581e62d
to
f5c5d78
Compare
|
This looks good but I think that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, external links resulting in a 404 error or other non success status codes will still pass the check.
With these changes, the user is now alerted about non success status codes from external links.